Shanghai has one of the best skylines, and the best place to see it is along The Bund. This waterfront view runs along the western bank of the Huangpu River. 
Be sure to check out The Bund at night to see the buildings light up on the Pudong District.
Here you can catch the Pearl Tower and Shanghai World Financial Center (the blue one that looks like a bottle opener) all lit up.

Location: